element-hq / element-hq/synapse

Update generated URLs to point to v3

Open
#11,474 0 comments 0 reactions 0 assignees View on GitHub
T-Task
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11474](https://github.com/matrix-org/synapse/issues/11474).

---

Related to #11079, we generate some URLs internally that point to `r0` URLs, some places we do this is for:

* Callback URLs used in SSO
* Attempting to fetch media from remote servers

Maybe other places. We should eventually update these to use `v3` URLs. The ones that generate URLs that go back to ourselves should be easy enough (if people have their reverse proxies configured properly), but the ones to other servers are a bit more complicated. For federation we try `v2` URLs then fallback to `v1` URLs, but that's rather annoying. Not sure if there's something better to do.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.