element-hq / element-hq/synapse
We don't seem to have proper coverage for legacy password auth provider modules
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 600
- Avg merge
- 5d 22h
- Merged PRs (30d)
- 51
Description
This issue has been migrated from [#11351](https://github.com/matrix-org/synapse/issues/11351).
---
As shown in https://github.com/matrix-org/synapse/pull/11340, the current incarnation of `load_legacy_password_auth_providers` just doesn't work except for auth checkers, but we didn't notice it until @reivilibre started poking around type annotations in this area.
Contributor guide
Research direction
Start with load_legacy_password_auth_providers and the behavior shown in PR #11340. Trace how legacy password auth provider modules are loaded, then add coverage for the provider cases that currently work only for auth checkers. Done means the tests demonstrate correct handling of the supported legacy provider modules.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- authentication, backend, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100