element-hq / element-hq/synapse

Sanity check the `review_recent_signups` script in CI

Open
#11,193 0 comments 0 reactions 0 assignees View on GitHub
P4 T-Task
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11193](https://github.com/matrix-org/synapse/issues/11193).

---

This is a regression that we missed. #11191 spotted it.

I think something similar to `test_synapse_port_db` would do the trick, i.e. a script that a) updates the sqlite DB stored in .ci and b) runs the recent signups script and checks there are no errors.

Could go further and try to actually interrogate the script's output, rather than just checking return code nonzero.

Contributor guide

Open the contributing guide

Research direction

Start by comparing the CI setup for test_synapse_port_db with the .ci SQLite database and the review_recent_signups script. Run the existing CI test and script to reproduce the regression. Done means the database is updated, the script runs without errors, and its output is checked if feasible.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, sqlite
Domain
ci-cd, database, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.