element-hq / element-hq/synapse

(Optionally?) provide trace IDs in all requests, even if open tracing is disabled

Open
#11,090 1 comment 0 reactions 0 assignees View on GitHub
T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11090](https://github.com/matrix-org/synapse/issues/11090).

---

On #10854 I lamented that it was a bit painful to track down logs for a particular request in a sytest run. In my ideal scenario, each response would have a unique string which identifies the request, so we can grep through logs for that.

One option was to always generate the trace id reported with opentracing, even if opentracing was disabled. I like this approach, and it might make it easier to track future problems reported by clients. See https://github.com/matrix-org/synapse/pull/10854#issuecomment-925749359 and https://github.com/matrix-org/synapse/pull/10854#issuecomment-933357047

Should probably convince ourselves that there aren't any privacy ramifications in doing this.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.