element-hq / element-hq/synapse

/ban does not validate the mxid

Open
#11,020 0 comments 0 reactions 0 assignees View on GitHub
S-Tolerable T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#11020](https://github.com/matrix-org/synapse/issues/11020).

---

`/_matrix/client/r0/rooms/{room}/ban` accepts bans for completely invalid mxids (for instance, those containing spaces, those containing trailing colons, etc). We should do some basic validation on the mxid to avoid cluttering the room state with useless membership events.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.