element-hq / element-hq/synapse

The `user_directory` table has a `room_id` column that seems to be unused.

Open
#10,770 0 comments 0 reactions 0 assignees View on GitHub
T-Task
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#10770](https://github.com/matrix-org/synapse/issues/10770).

---

I thought it might be early intention to support per-room user directory entries, but there's also a UNIQUE index on `user_id`, so the table makes this impossible currently.

It's unclear why this is here, but the question now is whether we want to do anything with it?

On librepush.net, `synapse=# select * from user_directory where room_id is not null;` gives me no rows (and I think I did check it was unused in the code the other day, *but I've slept since then!*).

I would suggest we eventually remove it if we're not going to use it, but that's a pain to do with SQLite (if I remember. Though we could still do it since we can assume SQLite homeservers are small).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.