element-hq / element-hq/synapse

Accepts invalid room tags

Open
#10,519 0 comments 0 reactions 0 assignees View on GitHub
S-Major T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#10519](https://github.com/matrix-org/synapse/issues/10519).

---

### Description

### Steps to reproduce

- setRoomTag "test" with body: `{"order":"string"}`
- getRoomTags returns `{"tags":{"test":{"order":"string"}}}` which is non-conforming to the [spec](https://github.com/matrix-org/matrix-doc/blob/master/data/api/client-server/tags.yaml#L67)

Synapse should reject invalid setRoomTag operations like Dendrite and Conduit do. Synapse should never return invalid data from getRoomTags.

### Version information

- **Version**: 1.39.0

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.