element-hq / element-hq/synapse

Investigate if `uvloop` with `asyncioreactor` gives some speedboosts

Open
#10,366 1 comment 0 reactions 0 assignees View on GitHub
T-Enhancement
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#10366](https://github.com/matrix-org/synapse/issues/10366).

---

From the [twisted 21.7.0.rc1 release](https://github.com/twisted/twisted/releases/tag/twisted-21.7.0rc1):
> twisted.internet.asyncioreactor.AsyncioSelectorReactor will no longer raise a TypeError like "SelectorEventLoop required, instead got: " (broken since 21.2.0).

[`uvloop`](https://uvloop.readthedocs.io/) is [pretty fast](http://magic.io/blog/uvloop-blazing-fast-python-networking/), and twisted can utilize asyncio event loops with `asyncioreactor`, so i wonder if some speed boosts could be gained by switching to `asyncioreactor` + `uvloop`, even if optionally.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.