element-hq / element-hq/synapse

Wrong type for /publicRooms limit

Open
#10,304 0 comments 0 reactions 0 assignees View on GitHub
A-Room-Directory A-Spec-Compliance P3 S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#10304](https://github.com/matrix-org/synapse/issues/10304).

---

According to https://spec.matrix.org/unstable/server-server-api/#get_matrixfederationv1publicrooms it should be an integer, but here it is stringified:

https://github.com/matrix-org/synapse/blob/a7a37437bc0364d6cde93f3ec264e06ed6324068/synapse/federation/transport/client.py#L425

Conduit errors when the parameter is a string.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.