element-hq / element-hq/synapse

email is not passed through to `check_registration_for_spam` hook with SSO registration

Open
#10,248 0 comments 0 reactions 0 assignees View on GitHub
S-Minor T-Defect
Dominant language
Python
Stars
4.6k
Forks
600
Avg merge
5d 22h
Merged PRs (30d)
51

Description

This issue has been migrated from [#10248](https://github.com/matrix-org/synapse/issues/10248).

---

the `check_registration_for_spam` hook is passed a parameter `email_threepid`: "The email threepid used for registering, if any".

However, when a user signs up via SSO, there is no "threepid" per se, even if we get an email address from the SSO provider, so the spam checker does not see the email address.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.