element-hq / element-hq/sygnal

Web Push gateway broken with some push provider

Open
#419 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
44
Forks
20
Avg merge
16h 53m
Merged PRs (30d)
1

Description

*This issue was originally created by [**@p1gp1g**](https://github.com/p1gp1g) at .*

Currently, hydrogen push notifications don't work if we don't use an explicitly allowed push service.

This is because sygnal has an [allow-list of authorized push service](https://github.com/matrix-org/sygnal/blob/main/sygnal/webpushpushkin.py#L170-L177). I guess this allow list has been added to avoid any kind of SSRF. Therefore a better solution would be to deny requests to private IPs for non-explicitly allowed push servers.

A random example from another project (there are other examples): https://github.com/discourse/discourse/blob/main/lib/final_destination/ssrf_detector.rb

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.