element-hq / element-hq/matrix-authentication-service
When completing a compatibility SSO login, if the login was already consumed the error page is confusing
- Dominant language
- Rust
- Stars
- 280
- Forks
- 111
- Avg merge
- 3d 1h
- Merged PRs (30d)
- 25
Description
*This issue was originally created by [**@sandhose**](https://github.com/sandhose) at .*
When a compatibility SSO login is being completed, MAS redirects to the client redirect_uri. If that URI is a native callback, it can happen that the browser window stays open, and sometimes even reload.
When that happens, the SSO login gets "consumed" twice, which currently gives this feedback:
Two things to fix:
- make the feedback more explicit (like "the login already completed" or something)
- make the redirect happen ~client side? Like display an HTML page with an `` or something, and a link on the page to open the callback
Contributor guide
Assessment
This issue has not been assessed yet.