element-hq / element-hq/element-x-ios

macOS: OIDC management isn't dismissed on sign out/dismissing Settings

Open
#1,615 0 comments 0 reactions 0 assignees View on GitHub
A-Authentication O-Uncommon S-Minor T-Defect
Dominant language
Swift
Stars
945
Forks
372
Avg merge
21h 42m
Merged PRs (30d)
67

Description

### Steps to reproduce

- Sign in with OIDC (seeing WAS prompt), open Settings and click `Account and devices` (again seeing WAS prompt).
- Sign out (leaving the Safari window open)
- Sign back in and see the Safari window focussed with the Account management page still shown.

### Outcome

#### What did you expect?
When signing out or dismissing the Settings screen we should dismiss the Safari window.

This *might* already be fixed given the latest build asks to open the browser rather than use the ASWebAuthenticationSession, I'm not sure what the behaviour on macOS is going to be like there.

### Your phone model

MacBook

### Operating system version

13.5.1

### Application version

1.2.6

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.