element-hq / element-hq/element-x-ios

It's not at all clear that the "Share my location" button is a button

Open
#1,486 3 comments 0 reactions 1 assignee Claimed by @amshakal View on GitHub
O-Frequent S-Minor T-Defect X-Needs-Design
Dominant language
Swift
Stars
945
Forks
372
Avg merge
21h 42m
Merged PRs (30d)
67

Description

### Steps to reproduce

1. Select "location" from the (+) button on the composer.
2. A popup card shows you the map with your location indicated with a (massive) pin-inside-a-pin. (sidenote: this feels way too big, and hides way too much surrounding map data; for instance, right now I can't even read the name of the street i'm on because the huge circle covers it. it feels like we have visibility-impaired mode enabled)
3. Look around for a button to press to share your location.
4. Notice there's a "Share my location" text at the bottom of the card. It looks a bit like a legend describing what the big pin means.
5. Look around some more
6. Realise that this text is actually a button you're meant to press in order to perform the share.

### Outcome

#### What did you expect?

I expected there to be some hint that the "Share this location" text at the bottom is actually a button you're meant to interact with, rather than a legend or some other informative text:

![image](https://github.com/vector-im/element-x-ios/assets/1294269/83af8d58-541e-488c-8f51-6911b551c4f5)

That could be via a green 'action' highlight of some kind, or making it look like a button (by putting it on a lozenge or whatever), or some other affordance. But right now there ain't no affordance.

#### What happened instead?

This is the 3rd time or so i've tried to share my location, and found myself flummoxed by the UI.

### Your phone model

_No response_

### Operating system version

_No response_

### Application version

340

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.