element-hq / element-hq/element-x-android

Turning Off Key Storage

Open
#5,992 0 comments 0 reactions 0 assignees View on GitHub
T-Enhancement X-Needs-Design
Dominant language
Kotlin
Stars
2.4k
Forks
624
Avg merge
1d 14h
Merged PRs (30d)
149

Description

### After toggling key storage off:
The background on the bullet points, along with the amount of red in the lower half, made the screen feel unbalanced.

Image

### Proposal

**1a.** Use the background from the bullet points on the main text.
**1b.** Or omit the background entirely.

**2.** Reduce the heading to: “Are you sure you want to turn off key storage?”

**3.** Replace:
**a.** “Deleting" with “Turning off”.
**b.** "remove" with "delete".
**c.** "Delete" with "Turn off"

- _“Turning off” reflects the user’s action: deletion/being removed is a byproduct._

**4.** Consider adding an option to download keys on this screen.

### Mock-up of bullets 1b, 2, 3a & 3b:

Image

### PS

●The delete button is large. Filling it with a bright colour can be jarring, especially in dark mode.
Perhaps a less vibrant colour or less of it.

### Are you willing to provide a PR?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.