element-hq / element-hq/element-x-android

R8 configuration doesn't optimize app

Open
#5,705 5 comments 1 reaction 0 assignees View on GitHub
Dominant language
Kotlin
Stars
2.4k
Forks
624
Avg merge
1d 14h
Merged PRs (30d)
149

Description

Your default current [R8 configuration](https://github.com/element-hq/element-x-android/blob/cbbd0ff079c8950bd4b76db22f7f878f80906a45/app/build.gradle.kts#L136C1-L137C1) does NOT optimize your application.
Instead of `proguard-android.txt` use `proguard-android-optimize.txt`

The [custom configuration](https://github.com/element-hq/element-x-android/blob/develop/app/proguard-rules.pro) keeps several wide namespaces [here](https://github.com/element-hq/element-x-android/blob/develop/app/proguard-rules.pro#L47-L53) and [here](https://github.com/element-hq/element-x-android/blob/develop/app/proguard-rules.pro#L10-L14), which should possibly replaced with narrower rules.

/cc @yncyrydybyl

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.