element-hq / element-hq/element-x-android

The string action.done is used in different contexts

Open
#4,435 0 comments 0 reactions 0 assignees View on GitHub
O-Occasional S-Minor T-Defect Z-UI-UX
Dominant language
Kotlin
Stars
2.4k
Forks
624
Avg merge
1d 14h
Merged PRs (30d)
149

Description

The string `action.done` ("Done") is used in different context and this is leading to mistake in translations.

It is used in the context of editing a Poll. In this case, the context is to save the edition.

Image

But also in the context of a finished or cancelled verification. In the case, the action will close the screen.

ImageImage

Last usage after the recovery key has been set up. In this case, the action will also close the screen.

Image

For instance in French, it is translated to "Terminé", which is correct, but not really for an action. "Terminer" ou "Fermer" would suit best, or even "Valider" in the context of editing a poll ("Sauvegarder" is probably too long).

So I suggest that we use separate strings to replace all the `action.done` instance. `Done` is not really an action anyway.

When the action is "close", we should use `action.close` and we the action is to save, we should use `action.save`. For the recovery key it's a bit specific because we want the user to save the key. So in this case, `action.done` is OK, but the French translation should be changed to "Fait". I cannot change the translation now because of the other usages of `action.done`. I believe French is not the only impacted languages with these inaccuracies.

Contributor guide

Open the contributing guide

Research direction

Search the Android project for every use of the `action.done` string and identify which screens save, close, or complete an action. Replace the context-specific usages with the appropriate separate strings, retain it for the recovery-key case, and update the affected French translation while checking other translations for the same ambiguity.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
localization, mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.