element-hq / element-hq/element-x-android
Make the PermissionsPresenter library follow the Android permission guidelines and merge it with the location’s PermissionsPresenter one
Open
T-Task
- Dominant language
- Kotlin
- Stars
- 2.4k
- Forks
- 624
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 149
Description
The permission library in `io.element.android.libraries.permissions.api.PermissionsPresenter` does not follow the Android best practices for runtime permissions management: https://developer.android.com/training/permissions/requesting .
In particular it tries to always display a custom dialog of ours before the system one.
We should have it conform to the Android guidelines and merge it with the similar (but location permission focused) library we have in the location feature package.
Contributor guide
Assessment
This issue has not been assessed yet.