element-hq / element-hq/element-x-android

Duplicated strings - BLOCKED UNTIL THE 2 APPS HAVE SAME FLOW

Open
#1,356 9 comments 0 reactions 0 assignees View on GitHub
O-Uncommon S-Minor T-Task Z-Wording
Dominant language
Kotlin
Stars
2.4k
Forks
624
Avg merge
1d 14h
Merged PRs (30d)
149

Description

There is an issue on Strings between iOS and Android application.

On Android, some strings have been added for submit buttons, like for instance:

https://github.com/vector-im/element-x-android/blob/develop/features/login/impl/src/main/res/values/localazy.xml#L40
```xml
"Continue"
```

instead of using the generic string
https://github.com/vector-im/element-x-android/blob/develop/libraries/ui-strings/src/main/res/values/localazy.xml#L19
```xml
"Continue"
```

The value is the same in English, but translations can differ (maybe not for this particular example though), which is not what we want.

We should simplify by removing the extra string entries, and use the generic value when it exists. It will reduce the number of strings to translate and will ensure that Android and iOS are synced. The drawback is that it will not be possible to tweak a value for a particular string by just updating Localazy.

We can use the find duplicate facilities on Localazy to detect identical strings, and probably remove all the duplicates.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.