element-hq / element-hq/element-web
`UIFeature.identityServer: false` does not seem to work like the documentation suggests
- Dominant language
- TypeScript
- Stars
- 13.5k
- Forks
- 2.8k
- PR merge metrics
- PR metrics pending
Description
### Steps to reproduce
1. Configure
```
"setting_defaults": {
"UIFeature.identityServer": false
}
```
According to the documentation at https://web-docs.element.dev/config.html#ui-features this regulates
> Whether or not functionality requiring an identity server is shown. When disabled, the user will not be able to interact with the identity server (sharing email addresses, 3PID invites, etc).
2. Click All Settings > Security & Privacy
As far as I can tell this was last touched with https://github.com/element-hq/element-web/commit/ea0baee1014e6cbf73b39c2502bc2f803d354983
Settings `UIFeature.thirdPartyId: false` results in no configuration option for an Identity server shown in the same Setting Menu.
### Outcome
#### What did you expect?
I do not see any settings related to an identity server
#### What happened instead?
The section is still shown:
### Operating system
Debian
### Browser information
LibreWolf 155.0.1-1
### URL for webapp
_No response_
### Application version
Element Web 1.12.27
### Homeserver
Synapse 1.160.0
### Will you send logs?
No
Contributor guide
Research direction
Start at the All Settings > Security & Privacy entry point and inspect how UIFeature.identityServer is handled, comparing it with UIFeature.thirdPartyId. Read the configuration documentation and linked commit ea0baee1014e6cbf73b39c2502bc2f803d354983. Done means setting UIFeature.identityServer to false hides identity-server-related settings as described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 66/100