element-hq / element-hq/element-web

Desktop does not delete all entries from keychain upon logout

Open
#32,249 0 comments 0 reactions 0 assignees View on GitHub
A-Electron A-Storage O-Uncommon S-Tolerable T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Login to Element Desktop (in this example on macOS)
2. Enter your Security Key
3. Open macOS Keychain
4. Search for Element and notice there are two "application passwords" that have been created. One is named in the format "seshat|@MXID|DEVICEID" and the other is named "@MXID|DEVICEID"
3. Log out of Element Desktop

### Outcome

#### What did you expect?
Both passwords are deleted from keychain

#### What happened instead?
Only one password is deleted from keychain

The one called "@MXID|DEVICEID" is deleted but the one called "seshat|@MXID|DEVICEID" is preserved. Presumably these passwords are useless after logging out so it isn't a security issue but we might as well clean them up rather than litter keychain with useless stuff.

### Operating system

macOS

### Browser information

_No response_

### URL for webapp

_No response_

### Application version

1.9.3

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.