element-hq / element-hq/element-web

A space general settings cancel action - does not visually cancel a space icon image change

Open
#31,773 2 comments 0 reactions 0 assignees View on GitHub
A-Spaces O-Occasional S-Minor T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. In a space home view
2. Press the space its gear icon to open its settings dialog
3. Upload a space icon image
4. Press cancel
5. With a space icon image being saved: press the delete button next to it
6. Press cancel

### Outcome

#### What did you expect?
- The settings dialog showing the space icon image according to the expected changes on cancel.

#### What happened instead?
- At 4. The space icon image is still visually present in the settings although it is cancelled
- At 6. The space icon image is not visually present in the settings although its deletion was cancelled.
- (Both are only a visual issue here, the cancel action was however correctly executed on saving the changes and exiting the dialog)

### Operating system

_No response_

### Browser information

_No response_

### URL for webapp

_No response_

### Application version

_No response_

### Homeserver

_No response_

### Will you send logs?

Yes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.