element-hq / element-hq/element-web

Canceling crypto reset in MAS doesn't cancel

Open
#31,562 1 comment 0 reactions 0 assignees View on GitHub
A-E2EE A-E2EE-Key-Backup O-Occasional S-Minor T-Enhancement
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Your use case

#### What would you like to do?
In the current flow when the user wants to reset his cryptographique identity, he has this first panel on EW :

Image

Then if it is connected to the MAS via OIDC native flow, it will ask to continue on the MAS :

Image

At this point all key backup versions and local secret storage about the keys are already deleted on EW. This page on MAS makes the user think that if he click on "Cancel" he will go back to his usual account, which is not correct, a part of the initialization has already been done.

Image

We can see below that if we don't finish the flow, the state of our crypto is still reinitialised

Image

#### Why would you like to do it?
It is confusing for the user to see his crypto state reinitialiseed even though he cancelled, or even having to see twice almost the same information about reinitializing his keys (once on EW and once on MAS).

The page shown in MAS is only to accept the upload of the keys. It should warn the user that a part of the initialisation is already done.
Same as the title and description asking of UIA which is "Go to your account to reset your identity", but in fact a part of the initialization has already be done. So it should be more "Go to your account to finalize the reset of your identity"

#### How would you like to achieve it?
Either redesigning/rewording UIA modale and MAS reset cross signing page or start the initialisation after receiving UIA confirmation

### Have you considered any alternatives?

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.