element-hq / element-hq/element-web

Don't offer to verify other devices if we don't have all the secrets

Open
#30,755 1 comment 0 reactions 0 assignees View on GitHub
A-E2EE A-E2EE-Cross-Signing O-Occasional S-Major T-Enhancement
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

Don't offer to verify other devices if we don't have all the secrets, because if we do verify them, we "infect" them with our lack of secrets, and they are invalid too.

If we have some unverified devices, normally we offer to verify them under Settings -> Sessions:

Image

We already don't offer this button if this device itself is unverified.

Extend this, so if we are missing some secrets, we also don't offer this button.

Design: https://www.figma.com/design/4wV2hrQvuQrDBiZW70DfqX/Compound-Web-Templates?node-id=2800-44636&t=vT74S9JypKqrrX1B-4

Image

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.