element-hq / element-hq/element-web

Errors processing device list changes are swallowed

Open
#30,149 0 comments 0 reactions 0 assignees View on GitHub
A-E2EE O-Uncommon S-Major T-Defect Team: Crypto
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

If there is a problem processing the `device_lists` part of a `/sync` response, the error is logged, but otherwise ignored. This is problematic because it means that, at some point in the future, we will cause unable-to-decrypt events.

It would be better to keep retrying the `/sync`, or to show an error box, than just to just carry on regardless, storing up problems for the future.

(We recently got UTD reports which turned out to be due to a [now-fixed bug](https://github.com/rustwasm/wasm-bindgen/issues/4352) in wasm-bindgen. The problem here isn't so much the bug in wasm-bindgen, as that other, similar bugs could cause UTDs.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.