element-hq / element-hq/element-web

Pinning and unpinning a message should ask for confirmation

Open
#28,399 4 comments 2 reactions 0 assignees View on GitHub
A-Message-Pinning O-Frequent T-Enhancement X-Needs-Product
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Your use case

#### What would you like to do?

Pinning a message sends a state event to the room, notifying all room members that a message has been pinned. This action should require a confirmation, such as a modal pop-up to ask the user whether they're sure.

#### Why would you like to do it?

It's easy to mis-click the "pin" or "unpin" button, as it's right next to "edit" and other actions on the message hotbar:

![image](https://github.com/user-attachments/assets/583a8bb9-8ff7-41fe-b8f9-15ad642fdce9)

#### How would you like to achieve it?

A modal pop-up, similar to Discord and other services, seems best.

![image](https://github.com/user-attachments/assets/20a9d05f-e476-4894-b755-372cd758001a)

### Have you considered any alternatives?

We could make it harder to find the button to pin things, but that seems counter-intuitive.

### Additional context

In Discord, if you hold down Shift while clicking on "pin/unpin", it skips the modal pop-up. This is a nice power-user feature.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.