element-hq / element-hq/element-web

Enable no floating promises rule

Open
#27,064 1 comment 5 reactions 0 assignees View on GitHub
A-Developer-Experience T-Task
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

In a quick discussion, we seems broadly in favour of enabling https://typescript-eslint.io/rules/no-floating-promises/ which mandates that promises returned from functions don't get discarded without being awaited on at some point. This will mean a few fixups to our codebase where we do deliberately not await on functions that are async because they need to do async stuff but we don't care about the result.

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Read the linked TypeScript ESLint no-floating-promises rule, then inspect the lint configuration and run the project's lint checks to find discarded promises; done means the rule is enabled and intentional fire-and-forget calls are handled without changing intended behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
eslint, typescript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.