element-hq / element-hq/element-web

Call "Permission" has changed in RoomHeader compared to LegacyRoomHeader

Open
#26,907 0 comments 0 reactions 0 assignees View on GitHub
A-Element-Call O-Frequent S-Major T-Defect Z-Labs
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

- Create a DM Room with user A
- Set user A role to "default" (not admin)
- Connect with user A to the DM, the call button is greyed with message : "You do not have permission to start voice calls"

### Outcome

With [LegacyRoomHeader](https://github.com/matrix-org/matrix-react-sdk/blob/81c62e51c474581c3d3f0f1e72aa0d1eb26ac45a/src/components/views/rooms/LegacyRoomHeader.tsx#L354) we don't have this behaviour, the button is not greyed. Indeed, as there are 2 people in the room, it is enough to activate the button.

With [RoomHeader](https://github.com/matrix-org/matrix-react-sdk/blob/ea3067b14583911fd202df2f3d86057822e6132a/src/hooks/room/useRoomCall.ts#L82) the new permission logic greys the call button and the user A can not make calls.

What is the reason of this new permission logic?

### Operating system

_No response_

### Browser information

_No response_

### URL for webapp

_No response_

### Application version

_No response_

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.