element-hq / element-hq/element-web

Refactor away the complexity in EntityTile component

Open
#26,493 0 comments 0 reactions 0 assignees View on GitHub
A-Technical-Debt O-Occasional S-Minor
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Your use case

We should remove some of the complexity from this component:
1. We probably don't need both `shouldShowPresence` and `suppressOnHover` props, one should be enough since they're both used to enable/disable rendering presence.
2. `subtextLabel` prop and the associated code for rendering it can also be removed since it's not used anywhere(?)

### Have you considered any alternatives?

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Search for the EntityTile component and usages of shouldShowPresence, suppressOnHover, and subtextLabel; read the component and its callers to understand the current presence-rendering behavior. Done means the redundant presence prop and unused subtextLabel code are removed without remaining references or changed behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.