element-hq / element-hq/element-web

Fully read marker is set at the bottommost message even if no message text is visible

Open
#26,062 0 comments 0 reactions 0 assignees View on GitHub
A-Read-Marker O-Occasional S-Tolerable T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Find a room with enough not-fully read messages to fill a screen. Move to the fully read marker.
2. Scroll down the timeline so that just the author name of (some) not fully read message is visible (see the screenshot).
![Screenshot_20230827_095656](https://github.com/vector-im/element-web/assets/10569730/094571b8-ae58-4cbd-a894-15a6d6ca99f9)

### Outcome

#### What did you expect?
The previous message is marked as fully read, not the one that only has the author name on the screen.

#### What happened instead?
The lowest technically-visible event is marked as fully read. Technical visibility does not coincide with common-sense visibility in this case: it's impossible to actually _read_ even the first line of that message.

It might make sense to mark the message as fully read only when its bottom edge is displayed, maybe?

### Operating system

Fedora Linux 38

### Browser information

Firefox 116.0.3

### URL for webapp

staging.element.io

### Application version

Element version: 1.11.40-rc.1

### Homeserver

matrix.org

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.