element-hq / element-hq/element-web

The "your message can't be sent; retry/discard" prompt doesn't push the timeline up.

Open
#24,575 0 comments 0 reactions 0 assignees View on GitHub
A-Timeline A-Timeline-Jumpy-Scroll O-Occasional S-Minor T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Unplug your internet
2. Try to send a message in a room
3. Note that the "can't be sent" warning pops up over the top of the message you just sent. It should (and used to) push the timeline up, but now the scroll position isn't preserved, so the prompt covers the message you just sent, making it superficially look like the message was eaten.

### Outcome

#### What did you expect?

Timeline scroll offset should be preserved even if we pop up messages at the bottom of the timeline.

#### What happened instead?

Timeline scroll offset is preserved relative to the bottom of the window, not the bottom of the prompt, making the prompt occlude the timeline and effectively "scroll up" the timeline without you performing a scroll operation.

### Operating system

macOS 13.1

### Application version

nightly desktop

### How did you install the app?

_No response_

### Homeserver

matrix.org

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.