GYU – Quick settings: Implement the "(default)" label

Open

#24,523 opened on Feb 14, 2023 0 comments 0 reactions 1 assignee Claimed by @justjanne View on GitHub

A-Notifications A-Room-List T-Enhancement Team: App Z-GetYourUpdates

Dominant language: TypeScript
Stars: 13.5k
Forks: 2.8k
PR merge metrics: PR metrics pending

Description

Designs: https://www.figma.com/file/M15i7l4PSPY1B5M7Zhu80H/Notifications?node-id=9040-138522&t=tDtJy79BQirt5h81-0

|How it looks today|How it looks in the new designs|
|-|-|
|![Screenshot 2023-03-20 at 12 54 07](https://user-images.githubusercontent.com/1137962/226331810-5914e515-cef3-45bf-8de9-01a194d85197.png)|![Screenshot 2023-03-20 at 12 53 46](https://user-images.githubusercontent.com/1137962/226331751-66bf035d-37bd-4327-9493-7cb48ce343d3.png)|

**Acceptance criteria**

* The option in the per-room tool-tip notification menu that matches the global notification setting has a suffix `... (Default)
* If for any reason we can't map a 'Default' (maybe users change their settings on a different client) then we drop this label - this shouldn't apply in too many cases

Blocks: https://github.com/vector-im/element-web/issues/24524

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

GYU – Quick settings: Implement the "(default)" label

Description

Contributor guide

Assessment

Get new issues in your inbox