element-hq / element-hq/element-web

Enter sends message even when IME composition is active

Open
#23,254 0 comments 0 reactions 0 assignees View on GitHub
A-Composer O-Occasional S-Major T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Configure your system to use the built-in macOS Japanese IME (in keyboard settings, add Japanese as an input source and select it for use)
2. Start typing a message, and verify that it's underlined, indicating that you're interacting with the IME
3. (Optional) press space and select an alternate conversion
4. Press enter

### Outcome

#### What did you expect?
The enter press goes to the IME only, telling it to end composition. The IME underline disappears, and nothing else happens. If you're in the conversion selection menu, the menu dismisses but no message is sent.

#### What happened instead?
Element uses the enter press as a signal that it should send the message

### Operating system

macOS 12.5.1(21G83)

### Browser information

Safari 15.6.1 (17613.3.9.1.16)

### URL for webapp

app.element.io

### Application version

Element version 1.11.4 Olm version 3.2.12

### Homeserver

matrix.org

### Will you send logs?

Yes

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.