element-hq / element-hq/element-web

Default margins of content elements in IRC layout

Open
#23,103 0 comments 0 reactions 1 assignee Claimed by @callumu View on GitHub
A-IRC-Layout O-Frequent S-Tolerable T-Defect X-Needs-Design
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

After the rejection of [this PR](https://github.com/matrix-org/matrix-react-sdk/pull/9134) I was encouraged to start a discussion about the problem in an issue here.

So there are default margins set for these content elements: `blockquote`, `dl`, `ol`, `p`, `pre`, `table`, `ul`. These default margins are removed with the IRC layout, but as far as I can see *only for the bottom margin of* `blockquote`. Here are the recycled screenshots from the PR:

overridden/removed bottom margin:

![blockquote1](https://user-images.githubusercontent.com/476060/182840131-2ebf5514-a906-43b2-924c-9c8562b9d5bc.png)

default margin:

![blockquote2](https://user-images.githubusercontent.com/476060/182840162-586c96f0-da23-4ba3-a220-4440d02bd4d5.png)

As I stated in the PR, it looks pretty ugly imho to have a blockquote have space above (bottom margin of previous element) but not a space below (overridden/removed default margin).

I was encouraged to start a discussion about whether that removal of default margins should be placed on *all* these elements in order to have the IRC layout be as compact as possible, or otherwise do not remove it from the blockquote bottom.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.