element-hq / element-hq/element-web

Element floods the server with registration requests if a registration fails

Open
#23,084 1 comment 0 reactions 0 assignees View on GitHub
O-Uncommon S-Major T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Configure Element to try to register against a server that returns an error on registration requests
2. Try to register
3. The server sends an error (I've observed this behaviour with both 400 (Unknown session ID) and 500 (Internal server error))

### Outcome

#### What did you expect?

Element does not retry registering.

#### What happened instead?

Element floods the homeserver with an endless loop of registration requests. On my local homeserver I've seen it send 1 request each ~5ms.

### Operating system

Arch Linux

### Browser information

Firefox 103.0.2

### URL for webapp

develop.element.io

### Application version

Element version: 39eee10c576f-react-9bf77963ee5e-js-3f6f5b69c7a1, olm version: 3.2.12

### Homeserver

Local development version of Synapse (based on 1.65.0rc2)

### Will you send logs?

Yes

Contributor guide

Open the contributing guide

Research direction

Reproduce the registration flow against a homeserver that returns 400 or 500, then trace the registration request loop from the web application entry point. Done means a failed registration stops retrying instead of sending requests continuously.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.