element-hq / element-hq/element-web

Disable Location Sharing if map_style_url is not provided

Open
#21,082 7 comments 3 reactions 1 assignee Claimed by @jakewb-b View on GitHub
A-Location-Sharing O-Uncommon S-Minor T-Enhancement X-Needs-Product Z-Labs
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

- Remove "map_style_url" from config.json or set it to blank.
- Try to share Location.
- You'll get an error message: "Failed to load map"

![image](https://user-images.githubusercontent.com/63514368/153923156-86966248-d6a6-43f2-a8d6-c007f626f1a2.png)

### Outcome

#### What did you expect?
Since map_style_url is not provided - the option to share Location should be hidden/disabled.
Alternatively, admins should be able to hide it within the "settingDefaults" section (e.g. set "UIFeature.shareLocation" to false).
Note that this feature requires registering for getting a key. I'm not sure all HS admins would do that, also some HS might want to disable it because of privacy concerns.

#### What happened instead?
Error message is shown.

### Application version
Element Web 1.10.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.