element-hq / element-hq/element-web

"Set a new custom sound" dialog has two buttons for choosing a file

Open
#20,864 5 comments 1 reaction 0 assignees View on GitHub
A-Notif-Panel O-Occasional S-Tolerable T-Defect X-Needs-Design
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

If one:

1. navigates to a room
2. opens up the room settings
3. clicks the Notifications settings tab, they will see the following.

![image](https://user-images.githubusercontent.com/1342360/152142888-f6e646f8-0ff1-4408-bc14-b69cb8b6adef.png)

One can use both `Choose File` or `Browse` buttons to choose a room-specific notification sound. They seem to do the same thing, but having two different buttons is confusing. A user may wonder if one does something different from the other.

### Outcome

#### What did you expect?

Just a single button. I would personally opt to keep the styled "Browse" button if possible.

#### What happened instead?

Two buttons?? Analysis paralysis!!

### Operating system

Arch Linux

### Application version

Element Nightly version: 2022012901, Olm version: 3.2.8

### How did you install the app?

https://aur.archlinux.org/packages/element-desktop-nightly-bin/

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.