element-hq / element-hq/element-web

Spotlight search can mislabel rooms with parted mxids

Open
#20,743 0 comments 0 reactions 0 assignees View on GitHub
A-Search A-Spotlight-Search O-Uncommon S-Major T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

* I hit cmd-K, and searched for Rick with spotlight on.
* One of the rooms returned was called "Rick" with rick's avatar, but was labelled with mxid `@random:example.com`
* This is scary as hell as it looks like `@random:example.com` is spoofing Rick

### Outcome

What happened is that i had a three-way private room with Rick and Random a few years ago. Random subsequently left, leaving it as me & Rick. The room has no name, so its name is shown as 'Rick'. However, as Random had left, his mxid should not be shown by spotlight.

### Operating system

_No response_

### Application version

Nightly

### How did you install the app?

_No response_

### Homeserver

_No response_

### Will you send logs?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.