element-hq / element-hq/element-web

Make AccessibleButton support a tabIndex mode

Open
#20,138 2 comments 0 reactions 0 assignees View on GitHub
A-Developer-Experience Hacktoberfest Help Wanted O-Uncommon S-Tolerable T-Task Z-t3chguy
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

Make `AccessibleButton` support a `tabIndex` mode instead of having to use a high order components (HOC) which gets really complex when you have other HOCs wrapping `AccessibleButton` already, e.g `ContextMenuButton`, `AccessibleTooltipButton`, now the combinations get infinite. Ideally we just have one Button component with a load of props, e.g `isContextMenuTrigger`, `tooltip`, `tabIndex=Roving` etc

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.