element-hq / element-hq/element-web
Encryption warning shouldn't display for restricted rooms in a public space
- Dominant language
- TypeScript
- Stars
- 13.5k
- Forks
- 2.8k
- PR merge metrics
- PR metrics pending
Description
### Steps to reproduce
1. Create a public space
2. Create a room with restricted join rules and add it to the space
### Outcome
#### What did you expect?
The warning shouldn't be displayed, because the restricted join rule combined with the public space makes this room effectively public.
#### What happened instead?
The warning was displayed, which could mislead the room's admins to enable encryption unnecessarily.
### Operating system
NixOS unstable
### Browser information
Firefox 92.0.1
### URL for webapp
develop.element.io
### Application version
Element version: 194aeac19e2d-react-965539da2d2c-js-b33b01df0f32 Olm version: 3.2.3
### Homeserver
townsendandsmith.ml
### Will you send logs?
No
Contributor guide
Assessment
This issue has not been assessed yet.