element-hq / element-hq/element-web

Rageshakes don't include uncaught exceptions

Open
#19,391 2 comments 0 reactions 0 assignees View on GitHub
A-Feedback-Reporting T-Task
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

Our rageshakes don't include uncaught exceptions logged to the browser console (ie. ones that bubble all the way up to the VM). Presumably because we just override console.log and the browser prints exceptions to the console itself. Exceptions that happen in react callbacks are generally OK because react catches them (and hopefully triggers our soft crash component). This means that exceptions can happen breaking the app but our rageshakes contains no evidence of them. This meant I was only able to diagnose https://github.com/vector-im/element-web/issues/19373 once a community member opened up their console and posted the exception: there was no evidence of an exception happening in Matthew's rageshake.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.