element-hq / element-hq/element-web
Don't include "reset all" link in the Access Secret Storage dialog if it's in the context of the verification dialog
- Dominant language
- TypeScript
- Stars
- 13.5k
- Forks
- 2.8k
- PR merge metrics
- PR metrics pending
Description
(Splitting this off from #19279 , which covered several independent UI bugs found while reviewing matrix-org/matrix-react-sdk#6811)
Now that the new device verification dialog has its own reset button, when you choose to verify using your recovery key/phrase, it's awkward for the resulting dialog to also have a reset button. Allow that UI component to be turned off if it's in a context where it's redundant/unnecessary.
Contributor guide
Research direction
Start by tracing the Access Secret Storage dialog used during recovery key/phrase verification and identify how its reset-all link is rendered. Check the surrounding verification-dialog flow to see how the component's context is passed. Done means the redundant reset-all link is absent there while remaining available in other contexts.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100