element-hq / element-hq/element-web

Change position of "Add" button in Spaces management to make it obvious how to add existing room to space

Open
#18,949 0 comments 0 reactions 0 assignees View on GitHub
A-Spaces O-Occasional S-Tolerable T-Enhancement X-Needs-Design Z-IA
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Problem

The placement of the `Add` button within the `Explore rooms` page suggests that it functions similarly to the nearby `Remove` and `Mark as not suggested` buttons. The lack of a `Select a room below first` tooltip and a separate button style isn't enough to differentiate the `Add` button from its inline button cousins.

In practice, this results in users (me) failing to add an existing room to a Space. I've forgotten the button's functionality even after using it multiple times :(

### Proposed solution

I've mocked up a different placement for the `Add` button that would (probably) communicate its functionality better.

![image](https://user-images.githubusercontent.com/23324896/132533908-4b9f41e9-db16-4a79-92ea-138b27230a18.png)

### Alternative solutions

Remove this Add button entirely, and defer to the `+` buttons beside People and Rooms in the channel tray.

Or if you'd like to go overkill, allow users to drag rooms from the channel tray onto icons in the Spaces tray.

### Additional context

This is a low-priority issue.

```
Element Nightly version: 2021062101
olm version: 3.2.3
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.