element-hq / element-hq/element-web

Missing error handling for when images didn't load properly

Open
#18,880 2 comments 0 reactions 1 assignee Claimed by @janogarcia View on GitHub
A-Media A-Timeline O-Occasional S-Minor T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

This one's __pretty hard__ to reproduce, at it requires both patchy internet and probably some decoding error, but it's quite easy to mock on dev environment. We need an image to fail loading somehow, mostly visible in E2E rooms.

### What happened?

Whenever images fail to load we keep on showing spinner/blurhash indefinitely.

### What did you expect?

Image changed to a failed state where we can click/tap it to retry loading.

Related: https://github.com/vector-im/element-web/issues/18819

### Operating system

_No response_

### Browser information

_No response_

### URL for webapp

_No response_

### Homeserver

_No response_

### Have you submitted a rageshake?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.