element-hq / element-hq/element-web

Membership event list summary hides leave events with no prior join when hidden events are enabled

Open
#18,785 0 comments 0 reactions 0 assignees View on GitHub
A-ELS A-Timeline O-Uncommon S-Tolerable T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

This one's a bit niche:

1. Enable 'Show Hidden Events' under labs
2. Crack open devtools in a room you're admin of
3. Send an `m.room.member` state event for a user ***not*** in the room, eg `@alice:localhost`, with membership `leave`
4. Do the same, but for a second user (`@bob:localhost`)

### What happened?

![image](https://user-images.githubusercontent.com/1190097/130876002-85ae35f1-f1b4-42d3-8e27-80f79a797637.png)

Only the first leave event is shown. It's clear that the second one is being trapped by MELS due to the lack of timestamp on the membership event (meaning the timeline code knows there's an event which follows, but it assumes that the grouping would take care of it). However, it did not get grouped.

### What did you expect?

For the second (hidden) membership event to be either part of a MELS or otherwise shown in the timeline, as it used to.

### Operating system

Windows 10

### Browser information

Edge 92.0.902.67 (Official build) (64-bit)

### URL for webapp

local build

### Homeserver

localhost (Synapse 1.40.0)

### Have you submitted a rageshake?

No

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.