element-hq / element-hq/element-web

localStorage / IndexDB write failures are fatal

Open
#18,423 10 comments 6 reactions 0 assignees View on GitHub
A-Storage O-Uncommon S-Critical T-Defect Z-TravisR
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Steps to reproduce

1. Run out of disk space or use a browser that disallows writing to localStorage, such as mobile safari in private mode
2. Perform an operation in Element Web that requires writing to localStorage. There are many of these cases all over the app.

### What happened?

A console error will usually be visible as we don't typically catch these exceptions.

The app will show undefined behaviour depending on what was prevented from happening; ranging from minor state not being preserved across sessions to irretrievable data loss of state that might only be held client side.

### What did you expect?

The app should gracefully handle localStorage write failure. It should inform the user and cleanly abort the current operation.

### Operating system

_No response_

### Application version

_No response_

### How did you install the app?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.