element-hq / element-hq/element-web
Dialog for Desktop Notifications should not appear when riot is inside an iframe
Open
A-Notifications
T-Defect
- Dominant language
- TypeScript
- Stars
- 13.5k
- Forks
- 2.8k
- PR merge metrics
- PR metrics pending
Description
I'll send a Pull Request for your evaluation.
The proposal is quite simple: only return `true` in `WebPlatform.supportsNotification()` if riot web is the top page, so that it will not appear when inside an iframe.
Contributor guide
Assessment
This issue has not been assessed yet.