element-hq / element-hq/element-web

Override, inherit, and default global and room URL preview settings

Open
#16,852 5 comments 0 reactions 0 assignees View on GitHub
A-Room-Settings A-URL-Previews A-User-Settings T-Defect X-Needs-Design
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Description

The URL previews feature has no effect. Turning it off in the preferences still enables them:

![image](https://user-images.githubusercontent.com/152227/113410419-a44ef880-93b3-11eb-9f3a-4e913b103fab.png)

### Steps to reproduce

1. Make URL previews work first, probably by turning this feature on
2. Now turn it off
3. I guess that's all?

Describe how what happens differs from what you expected.

Very simple: if I turn off URL previews, I want them turned off. There's really not much more to it.

Logs being sent: yes

### Version information

- **Platform**: desktop
- **OS**: Windows 10
- **Version**: 1.7.24

Contributor guide

Open the contributing guide

Research direction

No files, tests, or entry points are named. Reproduce the URL preview setting behavior on desktop, then trace where global and room preferences are read and combined; done means disabling previews works and the global, room, inherited, and default settings follow the intended precedence.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.