element-hq / element-hq/element-web

Adding a new server to the room directory is unreliable in validating the new server

Open
#15,724 1 comment 0 reactions 0 assignees View on GitHub
A-Room-Directory O-Occasional S-Minor T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

It feels like several things might be going wrong:
* We might be debouncing the text input too aggressively, meaning the validation can lag by several seconds
* We might be getting stuck behind trying to look up nonexistent hosts, causing the validation to lag
* We might not be rechecking the lookup once the user has finished typing
* We might not be cancelling previous lookups as the user types, causing the validation to fall behind

...and apparently we expect a raw servername rather than an https:// URL, which isn't made clear from the placeholder text.

Eitherway, the result is that it's very easy to get a validation fail like this for a hostname which is actually valid:

Screenshot 2020-11-14 at 00 30 42

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.