element-hq / element-hq/element-web

Logout request gets lost after setting up key backup

Open
#15,522 0 comments 0 reactions 0 assignees View on GitHub
A-Login A-SSO P2 S-Minor T-Defect
Dominant language
TypeScript
Stars
13.5k
Forks
2.8k
PR merge metrics
PR metrics pending

Description

### Description

If you're logged in with SSO but don't have key backup setup the logout request gets lost after setting up key backup

### Steps to reproduce
- As a user logged in with SSO but without key backup setup
- Attempt to logout
- See the following dialogue
![image](https://user-images.githubusercontent.com/1325121/96747381-1dd3cb00-13c0-11eb-9d2f-c9fd909f70f7.png)
- Go through the confirm device with SSO flow (which confused the user I was helping, nothing in the above screenshot suggested to them that they'd be asked to login again while they're trying to logout)
- After the device has been confirmed the user remained logged in

Describe how what happens differs from what you expected.

The user was expecting to either be logged out or to see
![image](https://user-images.githubusercontent.com/1325121/96748131-0ea14d00-13c1-11eb-950a-02021f0b32e3.png)

### Version information
- **Platform**: web

For the web app:

- **Browser**: Firefox
- **OS**: Windows I believe
- **URL**: Private instance 1.7.9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.